Add resizing plot feature and created tests for this feature.#579
Merged
Conversation
nickmelnikov82
requested review from
HammadTheOne and
alexcjohnson
as code owners
September 28, 2021 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #545
About
I am adding a feature to an existing component.
Description of changes
Create a new feature.
I added height and width properties to the NeedlePlot component and fragment. In the NeedlePlot component, I add height and width properties as well set them. In the NeedlePlot component, I gave the div and plot component these properties.
Also, I created tests for checking that these properties work as expected.